Skip to content

v1.18: Deprecate RpcRequest::GetStakeActivation (backport of #2005)#2012

Merged
CriesofCarrots merged 1 commit intov1.18from
mergify/bp/v1.18/pr-2005
Jul 8, 2024
Merged

v1.18: Deprecate RpcRequest::GetStakeActivation (backport of #2005)#2012
CriesofCarrots merged 1 commit intov1.18from
mergify/bp/v1.18/pr-2005

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Jul 4, 2024

Problem

I forgot to deprecate solana_rpc_client_api::request::RpcRequest::GetStakeActivation in #1895

Summary of Changes

Deprecate it
Also, make RpcClient deprecation-tag notes more correct while I'm here


This is an automatic backport of pull request #2005 done by [Mergify](https://mergify.com).

* Correct deprecation note

* Deprecate rpc-client-api request

(cherry picked from commit 0deb6fb)
@mergify mergify Bot requested a review from a team as a code owner July 4, 2024 08:20
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Jul 4, 2024

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @mergify[bot].

@CriesofCarrots CriesofCarrots requested a review from t-nelson July 5, 2024 17:35
@CriesofCarrots CriesofCarrots merged commit 1fab40d into v1.18 Jul 8, 2024
@CriesofCarrots CriesofCarrots deleted the mergify/bp/v1.18/pr-2005 branch July 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants